Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mixins: Add code/grpc-code dimension to error widgets #6231

Merged
merged 12 commits into from
Mar 31, 2023
Merged

mixins: Add code/grpc-code dimension to error widgets #6231

merged 12 commits into from
Mar 31, 2023

Conversation

douglascamata
Copy link
Contributor

@douglascamata douglascamata commented Mar 21, 2023 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Changed HTTP/gRPC error widgets to use a new function that can slice them by code/grpc-code (respectively). This allows the label of the series in the error charts to be much more useful than they are today.

Screenshots

Store gRPC error widget before changes

image

Store gRPC error widget after changes

image

Verification

Used the output query in my team's live Grafana dashboard.

@douglascamata
mixins: Add code/grpc-code dimension to error widgets
4bf3c05 
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
@douglascamata
Update changelog
9d8122a 
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
fpetkovski
fpetkovski previously approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@fpetkovski fpetkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@douglascamata douglascamata mentioned this pull request Mar 21, 2023
Merged
2 tasks
douglascamata
douglascamata commented Mar 22, 2023
View reviewed changes
mixin/lib/thanos-grafana-builder/builder.libsonnet
@@ -78,6 +78,24 @@ local utils = import '../utils.libsonnet';
],
},

qpsErrTotalPerLabelPanel(selectorErr, selectorTotal, dimensions, perLabel):: {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a decision documented: I created this qpsErrTotalPerLabelPanel function because in many places qpsErrTotalPanel is used for generic error charts (i.e. in the Compactor and Ruler dashboards).

As future work we could investigate whether those widgets have some sort of code/reason/message field that is worth surfacing in the widget's legend.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 23, 2023
douglascamata
douglascamata commented Mar 23, 2023
View reviewed changes
CHANGELOG.md Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG I messed up a merge conflict solution here. Fixing it.

@pull-request-size pull-request-size bot added size/M and removed size/L labels Mar 23, 2023
@douglascamata
Fix messed up merge conflict resolution
877f40f 
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
@douglascamata
Readd empty line at the end of changelog
037096d 
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
@douglascamata
Copy link
Contributor Author

Looks like we have a flake unit test?

--- FAIL: TestMultiTSDBPrune (6.14s)
    --- FAIL: TestMultiTSDBPrune/prune_tsdbs_with_object_storage (3.07s)
        testutil.go:91: multitsdb_test.go:475: ""
            
            	exp: 2
            
            	got: 1
            
FAIL

@douglascamata
Rerun CI
90d2c40 
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
@douglascamata
Merge branch 'main' of github.com:douglascamata/thanos into improve-e…
b010ae8 
…rror-dashboards
@douglascamata
Merge branch 'main' of github.com:thanos-io/thanos into improve-error…
9ec46ab 
…-dashboards

Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
@douglascamata
Copy link
Contributor Author

Build's all green, this is good to go finally 🙇

fpetkovski
fpetkovski approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@fpetkovski fpetkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fpetkovski fpetkovski merged commit b5560c1 into thanos-io:main Mar 31, 2023
@douglascamata douglascamata mentioned this pull request Apr 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpetkovski fpetkovski fpetkovski approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@douglascamata @fpetkovski